use references when possible

This commit is contained in:
sentriz
2019-06-05 17:34:01 +01:00
parent 406b133713
commit 146f157782
11 changed files with 128 additions and 115 deletions

View File

@@ -84,13 +84,13 @@ func makeRequest(method string, params url.Values) (*LastFM, error) {
}
defer resp.Body.Close()
decoder := xml.NewDecoder(resp.Body)
var lastfm LastFM
err = decoder.Decode(&lastfm)
lastfm := &LastFM{}
err = decoder.Decode(lastfm)
if err != nil {
return nil, errors.Wrap(err, "decoding")
}
if lastfm.Error != nil {
return nil, fmt.Errorf("parsing: %v", lastfm.Error.Value)
}
return &lastfm, nil
return lastfm, nil
}