heimoshuiyu/gonic
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix: make sure open cover and audio files are closed after use

Browse Source
This commit is contained in:
sentriz
2021-11-20 16:30:52 +00:00
committed by Senan Kelly
parent e10c8bafdf
commit 1d1ab116cd
2 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
server/mockfs/mockfs.go
View File

@@ -206,9 +206,11 @@ func (m *MockFS) AddTrack(path string) {
if err := os.MkdirAll(dir, os.ModePerm); err != nil { if err := os.MkdirAll(dir, os.ModePerm); err != nil {
m.t.Fatalf("mkdir: %v", err) m.t.Fatalf("mkdir: %v", err)
} }
if _, err := os.Create(abspath); err != nil { f, err := os.Create(abspath)
if err != nil {
m.t.Fatalf("create track: %v", err) m.t.Fatalf("create track: %v", err)
} }
defer f.Close()
} }
func (m *MockFS) AddCover(path string) { func (m *MockFS) AddCover(path string) {
@@ -216,9 +218,11 @@ func (m *MockFS) AddCover(path string) {
if err := os.MkdirAll(filepath.Dir(abspath), os.ModePerm); err != nil { if err := os.MkdirAll(filepath.Dir(abspath), os.ModePerm); err != nil {
m.t.Fatalf("mkdir: %v", err) m.t.Fatalf("mkdir: %v", err)
} }
if _, err := os.Create(abspath); err != nil { f, err := os.Create(abspath)
if err != nil {
m.t.Fatalf("create cover: %v", err) m.t.Fatalf("create cover: %v", err)
} }
defer f.Close()
} }
func (m *MockFS) SetTags(path string, cb func(*Tags)) { func (m *MockFS) SetTags(path string, cb func(*Tags)) {

1
server/podcasts/podcasts.go
View File

@@ -445,6 +445,7 @@ func (p *Podcasts) downloadPodcastCover(podPath string, podcast *db.Podcast) err
if err != nil { if err != nil {
return fmt.Errorf("creating podcast cover: %w", err) return fmt.Errorf("creating podcast cover: %w", err)
} }
defer coverFile.Close()
if _, err := io.Copy(coverFile, resp.Body); err != nil { if _, err := io.Copy(coverFile, resp.Body); err != nil {
return fmt.Errorf("writing podcast cover: %w", err) return fmt.Errorf("writing podcast cover: %w", err)
} }