heimoshuiyu/gonic
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

use package level require/assert in tests (#382)

Browse Source
This commit is contained in:
Senan Kelly
2023-09-25 19:39:39 +02:00
committed by GitHub
parent 548ab4f51c
commit 39fb8e7d54
8 changed files with 337 additions and 372 deletions
Download Patch File Download Diff File Expand all files Collapse all files

134
jukebox/jukebox_test.go
View File

@@ -38,9 +38,8 @@ func TestPlaySkipReset(t *testing.T) {
t.Parallel()
j := newJukebox(t)
require := require.New(t)
require.NoError(j.SetPlaylist([]string{
require.NoError(t, j.SetPlaylist([]string{
testPath("tr_0.mp3"),
testPath("tr_1.mp3"),
testPath("tr_2.mp3"),
@@ -49,56 +48,56 @@ func TestPlaySkipReset(t *testing.T) {
}))
status, err := j.GetStatus()
require.NoError(err)
require.Equal(0, status.CurrentIndex)
require.Equal(testPath("tr_0.mp3"), status.CurrentFilename)
require.Equal(5, status.Length)
require.Equal(true, status.Playing)
require.NoError(t, err)
require.Equal(t, 0, status.CurrentIndex)
require.Equal(t, testPath("tr_0.mp3"), status.CurrentFilename)
require.Equal(t, 5, status.Length)
require.Equal(t, true, status.Playing)
items, err := j.GetPlaylist()
require.NoError(err)
require.NoError(t, err)
itemsSorted := append([]string(nil), items...)
sort.Strings(itemsSorted)
require.Equal(itemsSorted, items)
require.Equal(t, itemsSorted, items)
require.NoError(j.Play())
require.NoError(t, j.Play())
status, err = j.GetStatus()
require.NoError(err)
require.Equal(true, status.Playing)
require.NoError(t, err)
require.Equal(t, true, status.Playing)
require.NoError(j.Pause())
require.NoError(t, j.Pause())
status, err = j.GetStatus()
require.NoError(err)
require.Equal(false, status.Playing)
require.NoError(t, err)
require.Equal(t, false, status.Playing)
require.NoError(j.Play())
require.NoError(t, j.Play())
// skip to 2
require.NoError(j.SkipToPlaylistIndex(2, 0))
require.NoError(t, j.SkipToPlaylistIndex(2, 0))
status, err = j.GetStatus()
require.NoError(err)
require.Equal(2, status.CurrentIndex)
require.Equal(testPath("tr_2.mp3"), status.CurrentFilename)
require.Equal(5, status.Length)
require.Equal(true, status.Playing)
require.NoError(t, err)
require.Equal(t, 2, status.CurrentIndex)
require.Equal(t, testPath("tr_2.mp3"), status.CurrentFilename)
require.Equal(t, 5, status.Length)
require.Equal(t, true, status.Playing)
// skip to 3
require.NoError(j.SkipToPlaylistIndex(3, 0))
require.NoError(t, j.SkipToPlaylistIndex(3, 0))
status, err = j.GetStatus()
require.NoError(err)
require.Equal(3, status.CurrentIndex)
require.Equal(testPath("tr_3.mp3"), status.CurrentFilename)
require.Equal(5, status.Length)
require.Equal(true, status.Playing)
require.NoError(t, err)
require.Equal(t, 3, status.CurrentIndex)
require.Equal(t, testPath("tr_3.mp3"), status.CurrentFilename)
require.Equal(t, 5, status.Length)
require.Equal(t, true, status.Playing)
// just add one more by overwriting the playlist like some clients do
// we should keep the current track unchaned if we find it
require.NoError(j.SetPlaylist([]string{
require.NoError(t, j.SetPlaylist([]string{
"testdata/tr_0.mp3",
"testdata/tr_1.mp3",
"testdata/tr_2.mp3",
@@ -108,24 +107,24 @@ func TestPlaySkipReset(t *testing.T) {
}))
status, err = j.GetStatus()
require.NoError(err)
require.Equal(3, status.CurrentIndex) // index unchanged
require.Equal(testPath("tr_3.mp3"), status.CurrentFilename)
require.Equal(6, status.Length) // we added one more track
require.Equal(true, status.Playing)
require.NoError(t, err)
require.Equal(t, 3, status.CurrentIndex) // index unchanged
require.Equal(t, testPath("tr_3.mp3"), status.CurrentFilename)
require.Equal(t, 6, status.Length) // we added one more track
require.Equal(t, true, status.Playing)
// skip to 3 again
require.NoError(j.SkipToPlaylistIndex(3, 0))
require.NoError(t, j.SkipToPlaylistIndex(3, 0))
status, err = j.GetStatus()
require.NoError(err)
require.Equal(3, status.CurrentIndex)
require.Equal(testPath("tr_3.mp3"), status.CurrentFilename)
require.Equal(6, status.Length)
require.Equal(true, status.Playing)
require.NoError(t, err)
require.Equal(t, 3, status.CurrentIndex)
require.Equal(t, testPath("tr_3.mp3"), status.CurrentFilename)
require.Equal(t, 6, status.Length)
require.Equal(t, true, status.Playing)
// remove all but 3
require.NoError(j.SetPlaylist([]string{
require.NoError(t, j.SetPlaylist([]string{
"testdata/tr_0.mp3",
"testdata/tr_1.mp3",
"testdata/tr_2.mp3",
@@ -133,25 +132,25 @@ func TestPlaySkipReset(t *testing.T) {
}))
status, err = j.GetStatus()
require.NoError(err)
require.Equal(3, status.CurrentIndex) // index unchanged
require.Equal(testPath("tr_3.mp3"), status.CurrentFilename)
require.Equal(4, status.Length)
require.Equal(true, status.Playing)
require.NoError(t, err)
require.Equal(t, 3, status.CurrentIndex) // index unchanged
require.Equal(t, testPath("tr_3.mp3"), status.CurrentFilename)
require.Equal(t, 4, status.Length)
require.Equal(t, true, status.Playing)
// skip to 2 (5s long) in the middle of the track
require.NoError(j.SkipToPlaylistIndex(2, 2))
require.NoError(t, j.SkipToPlaylistIndex(2, 2))
status, err = j.GetStatus()
require.NoError(err)
require.Equal(2, status.CurrentIndex) // index unchanged
require.Equal(testPath("tr_2.mp3"), status.CurrentFilename)
require.Equal(4, status.Length)
require.Equal(true, status.Playing)
require.Equal(2, status.Position) // at new position
require.NoError(t, err)
require.Equal(t, 2, status.CurrentIndex) // index unchanged
require.Equal(t, testPath("tr_2.mp3"), status.CurrentFilename)
require.Equal(t, 4, status.Length)
require.Equal(t, true, status.Playing)
require.Equal(t, 2, status.Position) // at new position
// overwrite completely
require.NoError(j.SetPlaylist([]string{
require.NoError(t, j.SetPlaylist([]string{
"testdata/tr_5.mp3",
"testdata/tr_6.mp3",
"testdata/tr_7.mp3",
@@ -160,33 +159,32 @@ func TestPlaySkipReset(t *testing.T) {
}))
status, err = j.GetStatus()
require.NoError(err)
require.Equal(0, status.CurrentIndex) // index unchanged
require.Equal(testPath("tr_5.mp3"), status.CurrentFilename)
require.Equal(5, status.Length)
require.Equal(true, status.Playing)
require.NoError(t, err)
require.Equal(t, 0, status.CurrentIndex) // index unchanged
require.Equal(t, testPath("tr_5.mp3"), status.CurrentFilename)
require.Equal(t, 5, status.Length)
require.Equal(t, true, status.Playing)
}
func TestVolume(t *testing.T) {
t.Parallel()
j := newJukebox(t)
require := require.New(t)
vol, err := j.GetVolumePct()
require.NoError(err)
require.Equal(100.0, vol)
require.NoError(t, err)
require.Equal(t, 100.0, vol)
require.NoError(j.SetVolumePct(69.0))
require.NoError(t, j.SetVolumePct(69.0))
vol, err = j.GetVolumePct()
require.NoError(err)
require.Equal(69.0, vol)
require.NoError(t, err)
require.Equal(t, 69.0, vol)
require.NoError(j.SetVolumePct(0.0))
require.NoError(t, j.SetVolumePct(0.0))
vol, err = j.GetVolumePct()
require.NoError(err)
require.Equal(0.0, vol)
require.NoError(t, err)
require.Equal(t, 0.0, vol)
}
func testPath(path string) string {