heimoshuiyu/gonic
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix(subsonic): return error code 70 for not found errors in more places

Browse Source 
fixes #454
This commit is contained in:
sentriz
2024-01-14 12:18:31 +00:00
parent e978716363
commit 42dbfa7a85
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
server/ctrlsubsonic/handlers_by_tags.go
View File

@@ -120,7 +120,7 @@ func (c *Controller) ServeGetAlbum(r *http.Request) *spec.Response {
First(album, id.Value). First(album, id.Value).
Error Error
if errors.Is(err, gorm.ErrRecordNotFound) { if errors.Is(err, gorm.ErrRecordNotFound) {
return spec.NewError(10, "couldn't find an album with that id") return spec.NewError(70, "couldn't find an album with that id")
} }
sub := spec.NewResponse() sub := spec.NewResponse()
sub.Album = spec.NewAlbumByTags(album, album.Artists) sub.Album = spec.NewAlbumByTags(album, album.Artists)
@@ -649,7 +649,7 @@ func (c *Controller) ServeGetSimilarSongs(r *http.Request) *spec.Response {
First(&track). First(&track).
Error Error
if errors.Is(err, gorm.ErrRecordNotFound) { if errors.Is(err, gorm.ErrRecordNotFound) {
return spec.NewError(10, "couldn't find a track with that id") return spec.NewError(70, "couldn't find a track with that id")
} }
similarTracks, err := c.lastFMClient.TrackGetSimilarTracks(track.TagTrackArtist, track.TagTitle) similarTracks, err := c.lastFMClient.TrackGetSimilarTracks(track.TagTrackArtist, track.TagTitle)
@@ -715,7 +715,7 @@ func (c *Controller) ServeGetSimilarSongsTwo(r *http.Request) *spec.Response {
First(&artist). First(&artist).
Error Error
if errors.Is(err, gorm.ErrRecordNotFound) { if errors.Is(err, gorm.ErrRecordNotFound) {
return spec.NewError(0, "artist with id %q not found", id) return spec.NewError(70, "artist with id %q not found", id)
} }
similarArtists, err := c.lastFMClient.ArtistGetSimilar(artist.Name) similarArtists, err := c.lastFMClient.ArtistGetSimilar(artist.Name)

2
server/ctrlsubsonic/handlers_common.go
View File

@@ -278,7 +278,7 @@ func (c *Controller) ServeGetSong(r *http.Request) *spec.Response {
First(&track). First(&track).
Error Error
if errors.Is(err, gorm.ErrRecordNotFound) { if errors.Is(err, gorm.ErrRecordNotFound) {
return spec.NewError(10, "couldn't find a track with that id") return spec.NewError(70, "couldn't find a track with that id")
} }
transcodeMeta := streamGetTranscodeMeta(c.dbc, user.ID, params.GetOr("c", "")) transcodeMeta := streamGetTranscodeMeta(c.dbc, user.ID, params.GetOr("c", ""))