From 4d844bd704bc7cfc7f5264be8ee90f27c401a602 Mon Sep 17 00:00:00 2001 From: sentriz Date: Sat, 6 Jul 2019 16:06:00 +0100 Subject: [PATCH] show scan status in ui --- scanner/scanner.go | 23 ++++++++++++++++++----- server/assets/pages/home.tmpl | 13 ++++++------- server/handler/handler_admin.go | 11 +++++++---- server/handler/handler_sub_common.go | 3 +-- server/handler/respond_admin.go | 1 + 5 files changed, 33 insertions(+), 18 deletions(-) diff --git a/scanner/scanner.go b/scanner/scanner.go index c09a907..00bb749 100644 --- a/scanner/scanner.go +++ b/scanner/scanner.go @@ -22,9 +22,22 @@ import ( "github.com/sentriz/gonic/scanner/tags" ) -// IsScanning acts as an atomic boolean semaphore. we don't +// isScanning acts as an atomic boolean semaphore. we don't // want to have more than one scan going on at a time -var IsScanning int32 +var isScanning int32 + +func IsScanning() bool { + return atomic.LoadInt32(&isScanning) == 1 +} + +func SetScanning(status bool) { + switch { + case status: + atomic.StoreInt32(&isScanning, 1) + default: + atomic.StoreInt32(&isScanning, 0) + } +} var coverFilenames = map[string]struct{}{ "cover.png": {}, @@ -91,11 +104,11 @@ func New(db *db.DB, musicPath string) *Scanner { } func (s *Scanner) Start() error { - if atomic.LoadInt32(&IsScanning) == 1 { + if IsScanning() { return errors.New("already scanning") } - atomic.StoreInt32(&IsScanning, 1) - defer atomic.StoreInt32(&IsScanning, 0) + SetScanning(true) + defer SetScanning(false) // // being walking start := time.Now() diff --git a/server/assets/pages/home.tmpl b/server/assets/pages/home.tmpl index 50aa81e..27ba16d 100644 --- a/server/assets/pages/home.tmpl +++ b/server/assets/pages/home.tmpl @@ -80,13 +80,12 @@ {{ end }} - start scan - {{ if not .LastScanTime.IsZero }} -
- - last completed: - {{ .LastScanTime | humanDate }} - + {{- if not .IsScanning -}} + start scan + {{- if not .LastScanTime.IsZero -}} +
+ scanned {{ .LastScanTime | humanDate }} + {{ end }} {{ end }} diff --git a/server/handler/handler_admin.go b/server/handler/handler_admin.go index d194a3f..20c916c 100644 --- a/server/handler/handler_admin.go +++ b/server/handler/handler_admin.go @@ -73,10 +73,8 @@ func (c *Controller) ServeHome(w http.ResponseWriter, r *http.Request) { ) data.RequestRoot = fmt.Sprintf("%s://%s", scheme, host) data.CurrentLastFMAPIKey = c.DB.GetSetting("lastfm_api_key") - if tStr := c.DB.GetSetting("last_scan_time"); tStr != "" { - i, _ := strconv.ParseInt(tStr, 10, 64) - data.LastScanTime = time.Unix(i, 0) - } + // + // users box c.DB.Find(&data.AllUsers) // // recent folders box @@ -85,6 +83,11 @@ func (c *Controller) ServeHome(w http.ResponseWriter, r *http.Request) { Order("updated_at DESC"). Limit(8). Find(&data.RecentFolders) + data.IsScanning = scanner.IsScanning() + if tStr := c.DB.GetSetting("last_scan_time"); tStr != "" { + i, _ := strconv.ParseInt(tStr, 10, 64) + data.LastScanTime = time.Unix(i, 0) + } // renderTemplate(w, r, c.Templates["home.tmpl"], data) } diff --git a/server/handler/handler_sub_common.go b/server/handler/handler_sub_common.go index 2812d84..5ce0bf7 100644 --- a/server/handler/handler_sub_common.go +++ b/server/handler/handler_sub_common.go @@ -5,7 +5,6 @@ import ( "net/http" "os" "path" - "sync/atomic" "time" "unicode" @@ -175,7 +174,7 @@ func (c *Controller) GetScanStatus(w http.ResponseWriter, r *http.Request) { Count(&trackCount) sub := subsonic.NewResponse() sub.ScanStatus = &subsonic.ScanStatus{ - Scanning: atomic.LoadInt32(&scanner.IsScanning) == 1, + Scanning: scanner.IsScanning(), Count: trackCount, } respond(w, r, sub) diff --git a/server/handler/respond_admin.go b/server/handler/respond_admin.go index 7080747..4e1f623 100644 --- a/server/handler/respond_admin.go +++ b/server/handler/respond_admin.go @@ -23,6 +23,7 @@ type templateData struct { RecentFolders []*model.Album AllUsers []*model.User LastScanTime time.Time + IsScanning bool // CurrentLastFMAPIKey string CurrentLastFMAPISecret string