From 7f60d984af15fe95f4817bded94222277bf5228e Mon Sep 17 00:00:00 2001 From: sentriz Date: Wed, 17 Jan 2024 13:12:10 +0000 Subject: [PATCH] reuse podcast http client --- podcast/podcast.go | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/podcast/podcast.go b/podcast/podcast.go index 17fc73b..af9c1aa 100644 --- a/podcast/podcast.go +++ b/podcast/podcast.go @@ -30,16 +30,18 @@ const ( ) type Podcasts struct { - db *db.DB - baseDir string - tagReader tagcommon.Reader + httpClient *http.Client + db *db.DB + baseDir string + tagReader tagcommon.Reader } func New(db *db.DB, base string, tagReader tagcommon.Reader) *Podcasts { return &Podcasts{ - db: db, - baseDir: base, - tagReader: tagReader, + db: db, + baseDir: base, + tagReader: tagReader, + httpClient: &http.Client{}, } } @@ -324,8 +326,7 @@ func (p *Podcasts) downloadPodcastCover(podcast *db.Podcast) error { } req.Header.Add("User-Agent", fetchUserAgent) - client := &http.Client{} - resp, err := client.Do(req) + resp, err := p.httpClient.Do(req) if err != nil { return fmt.Errorf("fetch image url: %w", err) } @@ -461,14 +462,13 @@ func (p *Podcasts) DownloadTick() error { } func (p *Podcasts) doPodcastDownload(podcast *db.Podcast, podcastEpisode *db.PodcastEpisode) (err error) { - client := &http.Client{} req, err := http.NewRequest(http.MethodGet, podcastEpisode.AudioURL, nil) if err != nil { return fmt.Errorf("create http request: %w", err) } req.Header.Add("User-Agent", fetchUserAgent) - resp, err := client.Do(req) + resp, err := p.httpClient.Do(req) if err != nil { return fmt.Errorf("fetch podcast audio: %w", err) }