heimoshuiyu/gonic
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

feat(ci): update golangci-lint and action (#325)

Browse Source 
* Update linter

- Update Github golangci-lint-action to v3
- Update golangci-lint to v1.52.2

* Fix linter issues after updating to linter 1.52.2
This commit is contained in:
Gregor Zurowski
2023-05-19 14:05:14 +02:00
committed by GitHub
parent ab07b876b8
commit 85eeb860bf
15 changed files with 43 additions and 62 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
scrobble/listenbrainz/listenbrainz_test.go
View File

@@ -17,7 +17,7 @@ import (
func httpClientMock(handler http.Handler) (http.Client, func()) {
server := httptest.NewTLSServer(handler)
client := http.Client{
shutdown := http.Client{
Transport: &http.Transport{
DialContext: func(ctx context.Context, network, addr string) (net.Conn, error) {
return net.Dial(network, server.Listener.Addr().String())
@@ -28,7 +28,7 @@ func httpClientMock(handler http.Handler) (http.Client, func()) {
},
}
return client, server.Close
return shutdown, server.Close
}
//go:embed testdata/submit_listens_request.json
@@ -39,7 +39,7 @@ func TestScrobble(t *testing.T) {
require := require.New(t)
// arrange
client, close := httpClientMock(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
client, shutdown := httpClientMock(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
require.Equal(http.MethodPost, r.Method)
require.Equal("/1/submit-listens", r.URL.Path)
require.Equal("application/json", r.Header.Get("Content-Type"))
@@ -51,7 +51,7 @@ func TestScrobble(t *testing.T) {
w.WriteHeader(http.StatusOK)
w.Write([]byte(`{"accepted": 1}`))
}))
defer close()
defer shutdown()
scrobbler := Scrobbler{
httpClient: &client,
@@ -79,7 +79,7 @@ func TestScrobbleUnauthorized(t *testing.T) {
require := require.New(t)
// arrange
client, close := httpClientMock(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
client, shutdown := httpClientMock(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
require.Equal(http.MethodPost, r.Method)
require.Equal("/1/submit-listens", r.URL.Path)
require.Equal("application/json", r.Header.Get("Content-Type"))
@@ -88,7 +88,7 @@ func TestScrobbleUnauthorized(t *testing.T) {
w.WriteHeader(http.StatusUnauthorized)
w.Write([]byte(`{"code": 401, "error": "Invalid authorization token."}`))
}))
defer close()
defer shutdown()
scrobbler := Scrobbler{
httpClient: &client,
@@ -116,7 +116,7 @@ func TestScrobbleServerError(t *testing.T) {
require := require.New(t)
// arrange
client, close := httpClientMock(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
client, shutdown := httpClientMock(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
require.Equal(http.MethodPost, r.Method)
require.Equal("/1/submit-listens", r.URL.Path)
require.Equal("application/json", r.Header.Get("Content-Type"))
@@ -124,7 +124,7 @@ func TestScrobbleServerError(t *testing.T) {
w.WriteHeader(http.StatusInternalServerError)
}))
defer close()
defer shutdown()
scrobbler := Scrobbler{
httpClient: &client,