feat(ci): add a bunch more linters

This commit is contained in:
sentriz
2023-09-22 19:05:20 +02:00
parent 33f1f2e0cf
commit e3dd812b6c
37 changed files with 233 additions and 139 deletions

View File

@@ -25,8 +25,10 @@ import (
var ErrNoAudioInFeedItem = errors.New("no audio in feed item")
const downloadAllWaitInterval = 3 * time.Second
const fetchUserAgent = `Mozilla/5.0 (Macintosh; Intel Mac OS X 10_7_5) AppleWebKit/537.11 (KHTML, like Gecko) Chrome/23.0.1271.64 Safari/537.11`
const (
downloadAllWaitInterval = 3 * time.Second
fetchUserAgent = `Mozilla/5.0 (Macintosh; Intel Mac OS X 10_7_5) AppleWebKit/537.11 (KHTML, like Gecko) Chrome/23.0.1271.64 Safari/537.11`
)
type Podcasts struct {
db *db.DB
@@ -96,7 +98,6 @@ func (p *Podcasts) AddNewPodcast(rssURL string, feed *gofeed.Feed) (*db.Podcast,
rootDir, err := fileutil.Unique(filepath.Join(p.baseDir, fileutil.Safe(feed.Title)), "")
if err != nil {
return nil, fmt.Errorf("find unique podcast dir: %w", err)
}
podcast := db.Podcast{
Description: feed.Description,
@@ -105,7 +106,7 @@ func (p *Podcasts) AddNewPodcast(rssURL string, feed *gofeed.Feed) (*db.Podcast,
URL: rssURL,
RootDir: rootDir,
}
if err := os.Mkdir(podcast.RootDir, 0755); err != nil && !os.IsExist(err) {
if err := os.Mkdir(podcast.RootDir, 0o755); err != nil && !os.IsExist(err) {
return nil, err
}
if err := p.db.Save(&podcast).Error; err != nil {
@@ -248,7 +249,8 @@ func isAudio(rawItemURL string) (bool, error) {
}
func itemToEpisode(podcastID, size, duration int, audio string,
item *gofeed.Item) *db.PodcastEpisode {
item *gofeed.Item,
) *db.PodcastEpisode {
return &db.PodcastEpisode{
PodcastID: podcastID,
Description: item.Description,

View File

@@ -17,6 +17,8 @@ import (
var testRSS []byte
func TestPodcastsAndEpisodesWithSameName(t *testing.T) {
t.Parallel()
t.Skip("requires network access")
m := mockfs.New(t)
@@ -62,6 +64,8 @@ func TestPodcastsAndEpisodesWithSameName(t *testing.T) {
}
func TestGetMoreRecentEpisodes(t *testing.T) {
t.Parallel()
fp := gofeed.NewParser()
newFeed, err := fp.Parse(bytes.NewReader(testRSS))
if err != nil {