we had the order of require.Equal() arguments mixed up. it should be
(expected, actual) not the other way around
updated with
find . -name "*_test.go" -exec gofmt -r "require.Equal(a, b) -> require.Equal(b, a)" -w '{}' \+
fixes#171fixes#31
* Initial code. Compiles and passes unit tests.
* Moved average rating calculation from rating fetch to set rating function. Still only compiled and unit tested.
* Bug fixes
* Fixed bug in savePlayQueue. Removed unique_index for star / rating entries because it's not valid.
* Changed time format on stars to RFC3339Nano to match created date format.
* Lint fixes.
* More lint fixes.
* Removed add* functions and replaced with Preload.
* Fixed several bugs in handlers for getStarred and getStarred2.
* Fixed bug when using music folder ID.
Co-authored-by: Brian Doherty <brian@hplaptop.dohertyfamily.me>
and never use db.Where() with a struct
gorm was seeing a query like
db.Where(Album{Left: left, Right: right})
but if the `left` variable was empty, gorm couldn't differentiate it with an empty field in the struct
so it generated SQL that we weren't expected
like
SELECT * FROM albums WHERE right=?
instead of
SELECT * FROM albums WHERE left=? AND right=?
fixes#230
* Initial commit of internet radio support.
* Added first test for internet radio.
* Refactor to prepare for more test cases.
* Added a few more tests. Realized that I was not calling as admin so added ability to mock admin.
* Added more internet radio tests. Added proper JSON unmarshaling for ID.
* More test cases. Fixed some accidental tabs in files.
* Fixed some more tabs.
* lint fixes
* Changed placeholder for homepage URL to fit into box.
* Finished out internet radio test cases. Found a few bad error codes in internet radio AND podcasts (mea culpa).
* Realized that delete via website was not checking properly if id existed. Fixed.
gofmt
sentriz
Gregor ZurowskiandGitHub
Brian Dohertyandsentriz
Duncan Overbruck