Commit Graph
10 Commits
Author SHA1 Message Date
Slavi Pantaleev e86a9ed952 Rename variable 2022-08-24 10:33:19 +03:00
Slavi Pantaleev 6103164881 Fix linting error 2022-08-24 10:31:42 +03:00
Slavi Pantaleev 16ce4314b9 Sanitize settings on Get() and add convenience getters
Sanitizing options on Get() ensures that when someone asks
for a given option which may not be defined (`nosubject`, `nosender`),
we'll return a valid value (`'true'` or `'false'`) and not `''` (empty
string, undefined).

This way, users do not need to wonder if "nosender is not set" is
handled like "true" or "false" or in some 3rd way. They also don't need
to think about "how to unset this setting, now that I've set it to something".
Options will appear to have a default sanitized value no matter if
they've explicitly been set or not.

The `NoSender()` and `NoSubject()` getters are just there for
convenience, so that we won't need to do casting in other places.
2022-08-24 10:16:28 +03:00
Slavi Pantaleev e4acbb31f0 Add nosubject option 2022-08-24 07:37:34 +03:00
Slavi Pantaleev a7e789fe56 Swap key/value parameters for setBooleanConfigurationKey()
Not that it matters much, but it's more consistent.
2022-08-23 18:44:13 +03:00
Slavi Pantaleev 9f3aa3dd68 Add ability to hide sender's email address (hide-sender-address setting)
The configuration setting is called `Hide*` instead of `Show*`, because
it's backward compatible with existing configuration settings.

This is useful for when you setup an email forwarding inbox and you're
always sending to it through the same email address. In that case, you
don't need to see the email address in each Matrix message.

In the future, another similar `bool` setting (`hide-subject`) will land,
which controls whether the email's subject is shown in the final message
or not. That setting can make use of most of the same setup (all of
`handleBooleanConfigurationKey`).
2022-08-23 18:21:23 +03:00
Slavi Pantaleev b79a728967 Use notice instead of error for expected "errors"
Notice() is like Error(), but:

- the message is not sent to the error log (and Sentry)
- the message sent to the room is not prefixed with `ERROR: `
2022-08-23 17:52:07 +03:00
Slavi Pantaleev 55a76c5c6b Use just Error, not Warn + Error
The downside of this is that the raw error gets reported to the user
in the room, instead of just being logged.
2022-08-23 17:45:15 +03:00
Slavi Pantaleev 726bc95c26 Suppress M_NOT_FOUND error when fetching settings
.. and ensure that getSettings() always returns either a default empty
settings object or an error.
2022-08-23 16:30:19 +03:00
Slavi PantaleevandAine fcac0a202d Make sure getSettings() always returns settings or error 2022-08-23 13:04:54 +00:00